Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph: return valid CIDR ip #12797

Merged
merged 1 commit into from
Aug 28, 2023
Merged

ceph: return valid CIDR ip #12797

merged 1 commit into from
Aug 28, 2023

Conversation

Madhu-1
Copy link
Member

@Madhu-1 Madhu-1 commented Aug 28, 2023

Description of your changes:

we need to return a valid CIDR IP to get it fenced properly, the previously returned one was like 10.63.0.5:0/32 which
is not a valid CIDR, removing :0 to look like the proper IP CIDR.

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

we need to return a valid CIDR IP
to get it fenced properly, the previously
returned one was like `10.63.0.5:0/32` which
is not a valid CIDR, removing `:0` to look like
proper IP CIDR.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@travisn travisn merged commit f352aac into rook:master Aug 28, 2023
48 of 50 checks passed
travisn added a commit that referenced this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants