Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

object: avoid creating same bucket for two different OBC #12804

Merged
merged 1 commit into from
Aug 31, 2023
Merged

object: avoid creating same bucket for two different OBC #12804

merged 1 commit into from
Aug 31, 2023

Conversation

thotz
Copy link
Contributor

@thotz thotz commented Aug 28, 2023 •
edited

Description of your changes:
If bucket exists for Provision(), then check whether user in the OBC and owner of bucket are same.

Which issue is resolved by this Pull Request:
Resolves #12389

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@thotz
object: avoid creating same bucket for two different OBC
b39e813 
If bucket exists for Provision(), then check whether user in the OBC and
owner of bucket are same.

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
travisn
travisn reviewed Aug 28, 2023
View reviewed changes
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fix #12389?

@parth-gr
Copy link
Member

And seems like it will also fix #12389

@subhamkrai
Copy link
Contributor

And seems like it will also fix #12389

@parth-gr do you mean to mention different issue numbers? looks similar to the one Travis mentioned above.

@thotz
Copy link
Contributor Author

thotz commented Aug 30, 2023

Does this fix #12389?

Yes it does need to verify this PR

@parth-gr
Copy link
Member

I meant this one #11345

@thotz
Copy link
Contributor Author

thotz commented Aug 31, 2023

I meant this one #11345

Thats different

@travisn travisn merged commit 35a86d4 into rook:master Aug 31, 2023
48 of 50 checks passed
This was referenced Aug 31, 2023
Merged
Merged
travisn added a commit that referenced this pull request Aug 31, 2023
@travisn
Merge pull request #12827 from rook/mergify/bp/release-1.12/pr-12804
5b42356 
object: avoid creating same bucket for two different OBC (backport #12804)
travisn added a commit that referenced this pull request Aug 31, 2023
@travisn
Merge pull request #12826 from rook/mergify/bp/release-1.11/pr-12804
65a956c 
object: avoid creating same bucket for two different OBC (backport #12804)
@thotz thotz deleted the check-owner-bucket-exist-grant branch September 4, 2023 10:06
@parth-gr parth-gr mentioned this pull request Sep 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

Assignees
No one assigned
Labels
backport-release-1.11 backport-release-1.12
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bucketName name collision results in deleted bucket
4 participants
@thotz @parth-gr @subhamkrai @travisn