external: change cluster_name to k8s_cluster_name #12811
Conversation
parth-gr
force-pushed
the
external-name
branch
from
71cc417
to
dcf0159
Compare
parth-gr
force-pushed
the
external-name
branch
from
dcf0159
to
1715f89
Compare
Updated |
it was confusing if we are calling a ceph cluster name or k8s cluster name, so re-named Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr
force-pushed
the
external-name
branch
from
1715f89
to
98c4567
Compare
| @@ -45,7 +45,7 @@ python3 create-external-cluster-resources.py --rbd-data-pool-name <pool_name> -- | |||
| - `--skip-monitoring-endpoint`: (optional) Skip prometheus exporter endpoints, even if they are available. Useful if the prometheus module is not enabled | |||
| - `--ceph-conf`: (optional) Provide a Ceph conf file | |||
| - `--keyring`: (optional) Path to Ceph keyring file, to be used with `--ceph-conf` | |||
| - `--cluster-name`: (optional) Ceph cluster name | |||
| - `--k8s-cluster-name`: (optional) Kubernetes cluster name | |||
There was a problem hiding this comment.
If someone is still using the --cluster-name flag will they get an error? It will be good to make it obvious that they need to rename the parameter.
There was a problem hiding this comment.
No there won't be any error,
The script is used at very start just to connect the cluster.
There was a problem hiding this comment.
Only during upgrade caps they need to take care of it to use new flag,
But which is already updated with the script description
There was a problem hiding this comment.
Could the script print an error if --cluster-name is passed? The error can tell them to instead use --k8s-cluster-name. This way, if someone doesn't look at the release notes they can quickly know they have need to rename this parameter.
There was a problem hiding this comment.
So if we use --cluster-name it will print all the correct flags that can be used
There was a problem hiding this comment.
Should we mention this in the release notes?
There was a problem hiding this comment.
Ok, so if they use --cluster-name, the script will already fail, thanks for confirming.
For the upstream release, all the commits are listed in the release notes, so it will already be covered.
external: change cluster_name to k8s_cluster_name (backport #12811)
Description of your changes:
it was confusing if we are calling a ceph cluster name or k8s cluster name, so re-named
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
skip-cion the PR.