Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Minimum and Maximum kubernetes version for the releases. #13632

Closed
smyja opened this issue Jan 26, 2024 · 6 comments
Closed

Add Minimum and Maximum kubernetes version for the releases. #13632

smyja opened this issue Jan 26, 2024 · 6 comments
Labels

Comments

@smyja
Copy link

smyja commented Jan 26, 2024

Is this a bug report or feature request?

  • Feature Request

What should the feature do:
Update the documentation with a table showing rook releases and their kubernetes version support. The older documentations just state the minimum version with no maximum version.
What is use case behind this feature:

Environment:

@smyja smyja added the feature label Jan 26, 2024
@travisn
Copy link
Member

travisn commented Jan 26, 2024

This is a common question, sounds good to clarify in the docs.

Currently in quickstart.md and prerequisites.md we have this:

## Minimum Version

Kubernetes **v1.22** or higher is supported.

I'm thinking this format:

## Kubernetes Version

Kubernetes versions v1.22 through v1.29 are supported.

Instead of trying to create a table of all K8s versions fo previous Rook versions, the K8s versions indicates approximately 6 K8s versions are supported from the min version.

The K8s versions tested in previous versions may also be reconstructed from the history of .mergify.yml. For example, in the release-1.8 branch, we see that the min and max version of K8s tested were v1.16 and v1.22:

      - "check-success=TestCephSmokeSuite (v1.16.15)"
      - "check-success=TestCephSmokeSuite (v1.22.2)"

@smyja
Copy link
Author

smyja commented Jan 26, 2024

This is a common question, sounds good to clarify in the docs.

Currently in quickstart.md and prerequisites.md we have this:

## Minimum Version

Kubernetes **v1.22** or higher is supported.

I'm thinking this format:

## Kubernetes Version

Kubernetes versions v1.22 through v1.29 are supported.

Instead of trying to create a table of all K8s versions fo previous Rook versions, the K8s versions indicates approximately 6 K8s versions are supported from the min version.

The K8s versions tested in previous versions may also be reconstructed from the history of .mergify.yml. For example, in the release-1.8 branch, we see that the min and max version of K8s tested were v1.16 and v1.22:

      - "check-success=TestCephSmokeSuite (v1.16.15)"
      - "check-success=TestCephSmokeSuite (v1.22.2)"

That would be great.

@parth-gr
Copy link
Member

@travisn Rook expects to support the most recent six versions of Kubernetes.
It looks me 7 for the above cases, for
rook 1.13 => 1.23-1.29 = 7
rook 1.12 => 1.22 -1.28 =7

@travisn
Copy link
Member

travisn commented Jan 31, 2024

@parth-gr Frequently it is rounded up to the 7th release if a K8s release comes out around the time of the Rook release.

@parth-gr
Copy link
Member

Okay

@travisn
Copy link
Member

travisn commented Jan 31, 2024

The docs for 1.12 and 1.13 have been updated. Going forward we will also document this in future releases. For support versions in previous releases, please see the versions tested as defined in the .mergify config.

@travisn travisn closed this as completed Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants