Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link to network configurations in cephClusterSpec #14249

Closed
NymanRobin opened this issue May 22, 2024 · 2 comments · Fixed by #14250
Closed

Broken link to network configurations in cephClusterSpec #14249

NymanRobin opened this issue May 22, 2024 · 2 comments · Fixed by #14250
Assignees
Labels

Comments

@NymanRobin
Copy link
Contributor

NymanRobin commented May 22, 2024

The link that describes the network configuration in deploy/charts/rook-ceph-cluster/values.yaml is dead

The old one is
https://github.com/rook/rook/blob/master/Documentation/CRDs/ceph-cluster-crd.md#network-configuration-settings

It seems this resource has actually moved to the following place
https://github.com/rook/rook/blob/master/Documentation/CRDs/Cluster/ceph-cluster-crd.md#network-configuration-settings

Fix is simply to update the link, but it could also be considered to add a CI check for dead links so this is easier to avoid in the future

@NymanRobin NymanRobin added the bug label May 22, 2024
@NymanRobin
Copy link
Contributor Author

/assign

Copy link

Thanks for taking this issue! Let us know if you have any questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant