Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rgw: add unit tests for the extrernal ceph object store reconciler #9025

Closed
leseb opened this issue Oct 25, 2021 · 5 comments · Fixed by #9710
Closed

rgw: add unit tests for the extrernal ceph object store reconciler #9025

leseb opened this issue Oct 25, 2021 · 5 comments · Fixed by #9710
Assignees
@rexagod
Labels
test unit or integration testing
Projects
v1.9

Comments

@leseb
Copy link
Member

leseb commented Oct 25, 2021

pkg/operator/ceph/object/controller_test.go does not have any test for an external CephObjectStore CR.
@leseb leseb added the test unit or integration testing label Oct 25, 2021
@leseb leseb mentioned this issue Oct 25, 2021
Merged
10 tasks
@leseb leseb added the beginner label Oct 25, 2021
@leseb leseb added this to To do in v1.8 via automation Oct 25, 2021
@rexagod
Copy link
Contributor

rexagod commented Dec 23, 2021

/assign

@rexagod
Copy link
Contributor

rexagod commented Dec 23, 2021 •
edited

@leseb I'd like to pick this up, can you please assign me to this issue?

Thanks!

@subhamkrai
Copy link
Contributor

@leseb I'd like to pick this up, can you please assign me to this issue?

Thanks!

done.

@rexagod rexagod mentioned this issue Feb 8, 2022
Merged
10 tasks
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@travisn travisn removed this from To do in v1.8 Feb 22, 2022
@travisn travisn added this to To do in v1.9 via automation Feb 22, 2022
@github-actions
Copy link

github-actions bot commented Mar 1, 2022

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.

@github-actions github-actions bot closed this as completed Mar 1, 2022
@BlaineEXE BlaineEXE removed the wontfix label Mar 2, 2022
@BlaineEXE BlaineEXE moved this from To do to In progress in v1.9 Mar 2, 2022
@BlaineEXE BlaineEXE reopened this Mar 2, 2022
@leseb leseb moved this from In progress to Done in v1.9 Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rexagod rexagod

Labels
test unit or integration testing
Projects
No open projects
v1.9
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rgw: add unit tests for the external ceph object store reconciler rexagod/rook
4 participants
@leseb @BlaineEXE @rexagod @subhamkrai