Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device_health_metrics pool defaults to "host" failure domain #9209

Closed
chinasubbareddym opened this issue Nov 18, 2021 · 1 comment · Fixed by #9363
Closed

device_health_metrics pool defaults to "host" failure domain #9209

chinasubbareddym opened this issue Nov 18, 2021 · 1 comment · Fixed by #9363
Labels
Projects

Comments

@chinasubbareddym
Copy link

Is this a bug report or feature request?

  • Bug Report

Deviation from expected behavior:
yes

Expected behavior:

should give us some option to change to different failure domain

How to reproduce it (minimal and precise):

by default device_health_metrics get created with crush rule of host based

File(s) to submit:

  • Cluster CR (custom resource), typically called cluster.yaml, if necessary
  • Operator's logs, if necessary
  • Crashing pod(s) logs, if necessary

To get logs, use kubectl -n <namespace> logs <pod name>
When pasting logs, always surround them with backticks or use the insert code button from the Github UI.
Read Github documentation if you need help.

Environment:

  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Cloud provider or hardware configuration:
  • Rook version (use rook version inside of a Rook Pod):
  • Storage backend version (e.g. for ceph do ceph -v):
  • Kubernetes version (use kubectl version):
  • Kubernetes cluster type (e.g. Tectonic, GKE, OpenShift):
  • Storage backend status (e.g. for Ceph use ceph health in the Rook Ceph toolbox):
@travisn
Copy link
Member

travisn commented Nov 19, 2021

To manage the built-in pool device_health_metrics, how about the following approach?

  • Create a CephBlockPool CR that has the desired settings, just like any other pool specification.
  • The CR name must be device-health-metrics. K8s does not allow underscores in resource names, so the operator will need to translate this special pool name into the correct pool device_health_metrics that ceph expects.
  • Support for changing the failure domain is needed in general for pools, which will be added now with pool: Update the desired failure domain when changed #9214.

@leseb leseb added this to To do in v1.8 via automation Nov 22, 2021
@travisn travisn moved this from To do to In progress in v1.8 Nov 30, 2021
@BlaineEXE BlaineEXE mentioned this issue Dec 8, 2021
10 tasks
@travisn travisn moved this from In progress to Blocking Release in v1.8 Dec 8, 2021
@travisn travisn moved this from Blocking Release to Review in progress in v1.8 Dec 9, 2021
v1.8 automation moved this from Review in progress to Done Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v1.8
Done
Development

Successfully merging a pull request may close this issue.

2 participants