Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment overrides are logged and don't follow zap config #71

Open
dave-lang opened this issue Nov 15, 2022 · 2 comments
Open

Environment overrides are logged and don't follow zap config #71

dave-lang opened this issue Nov 15, 2022 · 2 comments

Comments

@dave-lang
Copy link

dave-lang commented Nov 15, 2022

We consolidate all logs to Datadog for analysis, this requires formats to be ingestible and there are no secrets/personal information in logs

In testing rk-boot, any environment or flag based config overrides are always logged out as an info log, this exposes any secrets being pushed down from the environment

LoggerEntryStdout.Info("Found ENV to override, applying...", zapFields...)

At the very least this should be a dev only level log.

They also ignore any Zap log configs as they are shipped before the log configuration is parsed. This is good during failures so the config can be diagnosed but bad as it breaks standardised parsing. This would be less of an issue if they weren't created in non-development environments.

@dongxuny
Copy link
Contributor

@dave-lang Sounds reasonable. The log level should be dev only as you mentioned. I will fix this issue.

@dave-lang
Copy link
Author

@dongxuny Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants