added sort functionality to search and category page #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @kanavmittal Could you show the functionality through a screen recorded video? |
|
How it will look on mobile screens? |
|
@roopeshsn sure |
RPReplay_Final1666021470.MP4@roopeshsn for mobile view |
Screen.Recording.2022-10-17.at.9.18.34.PM.mov@roopeshsn for desktop view |
|
@roopeshsn anything needed? |
Yeah |
roopeshsn
requested changes
Oct 24, 2022
| @@ -5,6 +5,7 @@ const Product = require('../models/productModel') | |||
| // @route GET /api/products | |||
| // @access Public | |||
| const getProducts = asyncHandler(async (req, res) => { | |||
| var sort_type, products | |||
There was a problem hiding this comment.
We're using camelCase so, change all occurrences to camelCase. If it is a constant (sort_type) use this naming convention CONSTANT_NAME
Also, don't use var, use const or let. Format the code using the prettier command. Check the package.json file.
|
Hey, @kanavmittal Are you not interested to get this PR merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@roopeshsn
This commit resolves #104