Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for abi-tags (adapted from Fedora's patch) #124

Closed
wants to merge 1 commit into from

Conversation

@Axel-Naumann
Copy link
Member

Hi Mattias,

Thanks for collecting those. How does this PR relate to http://reviews.llvm.org/D12834 ?

Cheers, Axel

@ellert
Copy link
Contributor Author

ellert commented Jan 2, 2016

The Fedora patch and the llvm review are very much related. The Fedora patch is based on the proposed changes - there is a reference to http://reviews.llvm.org/D12834?id=34645 in the Fedora patch. Making a diff between the Fedora patch and the llvm review shows no significant changes (there are differences because the diffs are generated with different tools).

The proposed changes here differs because the patch must be adapted to the llvm version used by root.

@Axel-Naumann
Copy link
Member

Hi Mattias,

Thanks for your PR! Here's the plan:

I will update llvm and clang still this month. Very likely that'll not be enough to give us GCC5 ABI support.

I will then take what's in D12834 and friends (there are a few follow-ups as far as I can see) and apply them for a round of tests. As long as it doesn't break GCC 4.9 we are better off than now.

Cheers, Axel.

@Axel-Naumann Axel-Naumann self-assigned this Jan 7, 2016
@12345ieee
Copy link

Another bug report related to this issue:
https://sft.its.cern.ch/jira/browse/ROOT-7895

I confirm that after applying this patch (against 44c8e52) everything seems to work well.
Debian sid, gcc 5.3.1

Thanks @ellert .

@Axel-Naumann
Copy link
Member

Hi,

I will import the current state of the patch under review with llvm / clang, instead of the original one proposed here. There have been significant changes since.

So yes - this will be dealt with (see also the open Jira tickets), but not exactly as proposed here.

Thanks anyway for the suggestion!

Cheers, Axel.

@ellert ellert deleted the abi-tags branch December 9, 2016 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants