-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cling] A failed compilation unloads more decls than strictly neccesary #10049
Comments
Hi @jalopezg-git, It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise. Sincerely, |
1 similar comment
Hi @jalopezg-git, It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise. Sincerely, |
Unfortunately the second reproducer still fails for me in |
I re-tested master. What I could see is that the reproducer still fails on linux but works fine on macos. I could also add that on lxplus with a large installation such as CMSSW or a LCG release the error needs several seconds to appear. Adding more eyes to the ticket... |
Describe the bug
A reverted transaction due to a failed compilation ends up removing decls / JITed symbols that should be left untouched.
Related issues: #6439, #7970, ROOT-10848, ROOT-6254, ROOT-8084, and ROOT-8245.
Expected behavior
Clean unload. Reverting a transaction should probably not touch template instantiations / emitted symbols that correspond to deserialized decls.
To Reproduce
or
Setup
ROOT master, Arch Linux x86_64
The text was updated successfully, but these errors were encountered: