Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DF] Add support for varied Snapshot #11218

Open
1 of 5 tasks
eguiraud opened this issue Aug 18, 2022 · 0 comments
Open
1 of 5 tasks

[DF] Add support for varied Snapshot #11218

eguiraud opened this issue Aug 18, 2022 · 0 comments

Comments

@eguiraud
Copy link
Member

eguiraud commented Aug 18, 2022

In presence of systematic variations registered with RDF with Vary, a Snapshot call could produce a TTree that contains extra branches for the different systematic variations.

To do

  • decide between extra branches and extra trees
  • figure out how the interaction with VariationsFor works
  • decide naming convention for varied branches

Then for the actual implementation:

  • add template specialization for RVariedAction<SnapshotHelper> and RVariedAction<SnapshotHelperMT> that does the right thing
  • fix RVariedAction::GetSampleCallback so that it does not only take the callback of the first helper (this might turn out to be an orthogonal issue, but it's in principle relevant as SnapshotHelper[MT] makes use of the sample callback mechanism
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants