New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TDatabasePDG::GetParticle(...) not being thread safe #11580

Closed

karuboniru opened this issue Oct 17, 2022 · 0 comments · Fixed by #13541

Assignees

Labels

bug

Projects

Fixed in 6.30/00

karuboniru commented Oct 17, 2022

Describe the bug

concurrent call to methods like TDatabasePDG::Instance()->GetParticle(xxx)->GetName() can cause segmentation violation. Even with ROOT::EnableImplicitMT() Set

Expected behavior

ROOT::EnableImplicitMT() should make TDatabasePDG::GetParticle(...) thread safe without user taking locks

To Reproduce

Any program calling TDatabasePDG::Instance()->GetParticle(xxx)->GetName() at different thread

Setup

ROOT Version: 6.26/06
Platform: Fedora 37 Beta
Compiler: g++ (GCC) 12.2.1 20220819 (Red Hat 12.2.1-2)

Additional context

https://root-forum.cern.ch/t/tdatabasepdg-is-not-thread-safe-while-creating-multiple-thread-only-instance-cause-log-spam/51957

The text was updated successfully, but these errors were encountered:

karuboniru added the bug label

Axel-Naumann self-assigned this

wdconinc mentioned this issue

fix: use TDatabasePDG as a singleton eic/EICrecon#416

Closed

7 tasks

c-dilks mentioned this issue

TDatabasePDG is not thread safe eic/EICrecon#417

Open

dpiparo self-assigned this

dpiparo mentioned this issue

[Montecarlo][11580] Make TDatabasePDG::GetParticle methods thread safe #13541

Merged

1 task

dpiparo closed this as completed in #13541

dpiparo added this to Issues in Fixed in 6.30/00 via automation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment