You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue serves as a reminder that the code behind #ifndef ROOFORMULA_HAVE_STD_REGEX in RooFormula.cxx can be removed once the minimum C++ standard for ROOT is raised to C++17, because then gcc 4.8 is not supported anymore anyway. At that point, std::regex probably also works with visual studio, so the #ifndef _MSC_VER check can probably be removed in the same go.
See #8583 as a reference for what files to check to know what the minimum supported C++ standard of ROOT is.
The text was updated successfully, but these errors were encountered:
guitargeek
changed the title
[RF] Remove RooFormulaCode for gcc <= 4.8 when minimum standard is raised to C++17
[RF] Remove RooFormula code for gcc <= 4.8 when minimum standard is raised to C++17
Dec 28, 2022
Okay that may be, I don't remember this very well. I have opened a PR to remove it and I'll just ask in the daily or group meeting if anyone has objections. Thanks for pointing this out!
It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.
It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.
This issue serves as a reminder that the code behind
#ifndef ROOFORMULA_HAVE_STD_REGEX
in RooFormula.cxx can be removed once the minimum C++ standard for ROOT is raised to C++17, because then gcc 4.8 is not supported anymore anyway. At that point,std::regex
probably also works with visual studio, so the#ifndef _MSC_VER
check can probably be removed in the same go.See #8583 as a reference for what files to check to know what the minimum supported C++ standard of ROOT is.
The text was updated successfully, but these errors were encountered: