Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RF] Remove RooFormula code for gcc <= 4.8 when minimum standard is raised to C++17 #11964

Closed
guitargeek opened this issue Dec 28, 2022 · 4 comments · Fixed by #11990
Closed

Comments

@guitargeek
Copy link
Contributor

This issue serves as a reminder that the code behind #ifndef ROOFORMULA_HAVE_STD_REGEX in RooFormula.cxx can be removed once the minimum C++ standard for ROOT is raised to C++17, because then gcc 4.8 is not supported anymore anyway. At that point, std::regex probably also works with visual studio, so the #ifndef _MSC_VER check can probably be removed in the same go.

See #8583 as a reference for what files to check to know what the minimum supported C++ standard of ROOT is.

@guitargeek guitargeek self-assigned this Dec 28, 2022
@guitargeek guitargeek changed the title [RF] Remove RooFormulaCode for gcc <= 4.8 when minimum standard is raised to C++17 [RF] Remove RooFormula code for gcc <= 4.8 when minimum standard is raised to C++17 Dec 28, 2022
@hahnjo
Copy link
Member

hahnjo commented Jan 9, 2023

I think already the switch to C++14 made GCC 4.8 effectively unsupported, so you may already be able to do this now?

@guitargeek
Copy link
Contributor Author

Okay that may be, I don't remember this very well. I have opened a PR to remove it and I'll just ask in the daily or group meeting if anyone has objections. Thanks for pointing this out!

@guitargeek guitargeek linked a pull request Jan 9, 2023 that will close this issue
@github-actions
Copy link

Hi @guitargeek,

It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.

Sincerely,
🤖

1 similar comment
@github-actions
Copy link

Hi @guitargeek,

It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.

Sincerely,
🤖

@guitargeek guitargeek added this to Issues in Fixed in: not applicable via automation Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants