Excessive Form usage in TMVA

[linev]

Check duplicate issues.

• Checked for duplicates

Description

There are many places where value of global buffer from Form stored in variable and used in several consequent calls.
Such behavior is undefined while global buffer may be changed by other calls.

Moreover, there are places (at least one) where two Form used in single call - definitely is not working.
See here:

https://github.com/root-project/root/blob/master/tmva/tmva/src/MethodTMlpANN.cxx#L456

      dummyTree->Branch(Form("%s",vn.Data()), d+ivar, Form("%s/D",vn.Data()));

One should use TString::Format() instead.

Reproducer

ROOT version

master

Installation method

build from source

Operating system

OpenSUSE Linux

Additional context

No response

[github-actions]

Hi @linev, @lmoneta,

It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.

Sincerely,
🤖