Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't open TBrowser locally after upgrading macos “Apple M2 14.0 (23A344)” #13834

Closed
1 task
WentaiLuo opened this issue Oct 10, 2023 · 30 comments · Fixed by #13885
Closed
1 task

Can't open TBrowser locally after upgrading macos “Apple M2 14.0 (23A344)” #13834

WentaiLuo opened this issue Oct 10, 2023 · 30 comments · Fixed by #13885
Assignees
Labels

Comments

@WentaiLuo
Copy link

WentaiLuo commented Oct 10, 2023

Check duplicate issues.

  • Checked for duplicates

Description

Today I upgraded my macos system to 14.0, downloaded the source code for v6.28/06 and compiled it, after that root works fine and drawing works fine, but TBrowser doesn't work!
WechatIMG150

Reproducer

run root -l
TBrowser a

and saw this picture
WechatIMG150

ROOT version

v6.28/06

Installation method

build from source

Operating system

MacOS

Additional context

No response

@WentaiLuo WentaiLuo added the bug label Oct 10, 2023
@Josiah1
Copy link

Josiah1 commented Oct 10, 2023

I also encountered this problem on the new Macos 14. Even in the ROOT prompt, I can draw plots normally, but if I click the menu "edit" or others, ROOT will crash.

@bellenot
Copy link
Member

I don't have access to a Mac. Maybe @couet can try?

@dpiparo
Copy link
Member

dpiparo commented Oct 10, 2023

I just tried on macos14 and pyroot. The browser opens fine. Can it be linked to the event loop?
In any case the web browser works very well, as a stop gap solution.
What I did not manage to reproduce is the crash upon clicking "Edit" when drawing a plot.

@Josiah1
Copy link

Josiah1 commented Oct 10, 2023

I just tried on macos14 and pyroot. The browser opens fine. Can it be linked to the event loop? In any case the web browser works very well, as a stop gap solution. What I did not manage to reproduce is the crash upon clicking "Edit" when drawing a plot.

Thanks for trying this. Can you just try the root prompt? And open a TBrowser, or draw a plot and then click the edit menu.

@couet
Copy link
Member

couet commented Oct 11, 2023

I just tried:

root [0] TBrowser B

It is fine with master on my mac
I will build 6.28

@couet
Copy link
Member

couet commented Oct 11, 2023

By the way, where did you take root from ? did you built it yourself ?

@WentaiLuo
Copy link
Author

WentaiLuo commented Oct 11, 2023

By the way, where did you take root from ? did you built it yourself ?

I downloaded the source code from the official website, https://root.cern/releases/release-62806/

I made no changes to the source code and subsequently compiled and installed root.

I think it's the macos upgrade that's causing this bug, because everything was fine before the upgrade.

@couet
Copy link
Member

couet commented Oct 11, 2023

Yes, but on that web page, there is no module for MacOS14 yet. That might be the cause of the problem because when I build it from sources on my MacOS 14 machine I have no problem with TBrowser. The version for macOS14 should come soon. Meanwhile, you can try to build from the sources if you want.

@couet couet added in:GUI and removed bug labels Oct 11, 2023
@WentaiLuo
Copy link
Author

Yes, but on that web page, there is no module for MacOS14 yet. That might be the cause of the problem because when I build it from sources on my MacOS 14 machine I have no problem with TBrowser. The version for macOS14 should come soon. Meanwhile, you can try to build from the sources if you want.

I'm sorry if I didn't make myself clear. I also build it from sources on my MacOS 14 machine.

@couet
Copy link
Member

couet commented Oct 11, 2023

It seems connected to M2 machines ...

@WentaiLuo
Copy link
Author

It seems connected to M2 machines ...

Bad news, my friend also built it from sources on MacOS14 machine, intel machine. And "TBrowser" is also not work.

@WentaiLuo
Copy link
Author

I also encountered this problem on the new Macos 14. Even in the ROOT prompt, I can draw plots normally, but if I click the menu "edit" or others, ROOT will crash.

Intel machine.

@couet
Copy link
Member

couet commented Oct 11, 2023

I just tried with a local build using "master" on my Intel MacOS machine 14.0 23A344
and it works:
Screenshot 2023-10-11 at 09 19 37

@WentaiLuo
Copy link
Author

I just tried with a local build using "master" on my Intel MacOS machine 14.0 23A344 and it works: Screenshot 2023-10-11 at 09 19 37

ok, I will try "master" sources.

@WentaiLuo
Copy link
Author

I just tried with a local build using "master" on my Intel MacOS machine 14.0 23A344 and it works: Screenshot 2023-10-11 at 09 19 37

I downloaded the master on github and ran root successfully after cmake.
TBrowser still doesn't work though, luckily the web version works.
截屏2023-10-11 16 01 39

@couet
Copy link
Member

couet commented Oct 11, 2023

TBrowser still doesn't work though

On both Intel and M2 ?

I was also thinking about Xcode, is there any update to be done on your machine(s) ?

@WentaiLuo
Copy link
Author

WentaiLuo commented Oct 11, 2023

TBrowser still doesn't work though

On both Intel and M2 ?

I was also thinking about Xcode, is there any update to be done on your machine(s) ?

M2 machine is a new one, so the Xcode v15.0 is installed for the latest version. Intel machine is my friend's, so I'm not quite sure.

@couet
Copy link
Member

couet commented Oct 11, 2023

I have also XCode 15 on my Intel machine

@couet
Copy link
Member

couet commented Oct 11, 2023

I see the issue on M2 now

@couet
Copy link
Member

couet commented Oct 11, 2023

It does not seem to be blocked because the GUI reacts the pull-down menus from the menu bar display correctly and the fit panel displays correctly also ...

@couet
Copy link
Member

couet commented Oct 11, 2023

Some news: We have an M1 machine, macphsft24, running MacOS14 but using clang 12.0.5. I installed ROOT master on it and TBrowser is working ... I see the bug on machines running clang 15. Can you type the command clang --version on the machines on which TBrowser is failing for you ? to see which version of clang you are using ...

@couet
Copy link
Member

couet commented Oct 11, 2023

clang 15 with MacOs 13.6 is working... (M1)

So it seems we need MacOS 14 AND clang 15 to get the problem.

Is it the case for the Intel machine of your friend?

@WentaiLuo
Copy link
Author

WentaiLuo commented Oct 12, 2023

Some news: We have an M1 machine, macphsft24, running MacOS14 but using clang 12.0.5. I installed ROOT master on it and TBrowser is working ... I see the bug on machines running clang 15. Can you type the command clang --version on the machines on which TBrowser is failing for you ? to see which version of clang you are using ...

M2 machine: clang version is 15.0.0(clang-1500.0.40.1)& MacOS 14

@WentaiLuo
Copy link
Author

WentaiLuo commented Oct 12, 2023

clang 15 with MacOs 13.6 is working... (M1)

So it seems we need MacOS 14 AND clang 15 to get the problem.

Is it the case for the Intel machine of your friend?

The intel machine is also clang 15.0.0 (clang-1500.0.40.1) & MacOS 14.

It does look like macOS 14 and clang 15 are causing the problem!

@aalkin
Copy link
Contributor

aalkin commented Oct 17, 2023

On my m2 with macos 14 I have the same issue with ROOT built with clang 15. However the older build, done before update to macos 14 with clang 14.0.3, still works on updated system as it links to previous versions of system libraries.
Output of otool -L bin/root
Current (with the issue):

	/System/Library/Frameworks/Cocoa.framework/Versions/A/Cocoa (compatibility version 1.0.0, current version 24.0.0)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 1600.151.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1336.0.0)
	/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit (compatibility version 45.0.0, current version 2483.0.0)
	/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 2048.1.255)
	/System/Library/Frameworks/Foundation.framework/Versions/C/Foundation (compatibility version 300.0.0, current version 2048.1.255)
	/usr/lib/libobjc.A.dylib (compatibility version 1.0.0, current version 228.0.0)

Old (works normally):

	/System/Library/Frameworks/Cocoa.framework/Versions/A/Cocoa (compatibility version 1.0.0, current version 23.0.0)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 1500.65.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1319.100.3)
	/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit (compatibility version 45.0.0, current version 2299.50.120)
	/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 1971.0.0)
	/System/Library/Frameworks/Foundation.framework/Versions/C/Foundation (compatibility version 300.0.0, current version 1971.0.0)
	/usr/lib/libobjc.A.dylib (compatibility version 1.0.0, current version 228.0.0)

@couet
Copy link
Member

couet commented Oct 17, 2023

As I told you on the forum, we are on it.

@BethLong06
Copy link

I have the same issue on intel and Clang 11.0.0 after updating to MacOS14

@couet
Copy link
Member

couet commented Oct 19, 2023

I do not see it with Intel Clang 12 and OSX 14. It is strange you see it with Clang 11. I am now updating my Intel machine to Clang 15 (the faulty one).
Anyway, this PR fixes the problem.

@couet
Copy link
Member

couet commented Oct 20, 2023

The PR that fixes these problems is now merged in master.

@couet couet added this to Issues in Fixed in 6.30/00 via automation Oct 20, 2023
@bellenot
Copy link
Member

@couet this is not (yet) fixed in 6.30/00

@bellenot bellenot removed this from Issues in Fixed in 6.30/00 Oct 20, 2023
@bellenot bellenot added this to Issues in Fixed in 6.32.00 via automation Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

7 participants