Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TH1 Integral incorrectly returns nan #6427

Closed
Dominic-Stafford opened this issue Sep 23, 2020 · 3 comments
Closed

TH1 Integral incorrectly returns nan #6427

Dominic-Stafford opened this issue Sep 23, 2020 · 3 comments
Assignees

Comments

@Dominic-Stafford
Copy link

Dear ROOT experts

I have produced some neural network output score, which I exported to ROOT histograms using uproot (as I am more familiar with that than pyROOT), so that I could set limits using the Higgs Combine tool. However in the Higgs Combine tool I encountered errors due to these histograms having nan integral. I presumed this problem may just have been caused by me outputting the histogram incorrectly, however when I investigated one of these histograms I found it had the property that hist.Integral(100, 100) gives nan, but hist.GetBinContent(100) gives 0.0, when I would assume these should always give the same result. What is the difference between these, please, and can anyone advise on where I might be going wrong?

Thank you

Dominic Stafford

@github-actions github-actions bot added this to Needs triage in Triage Sep 23, 2020
@lmoneta lmoneta self-assigned this Sep 24, 2020
@lmoneta
Copy link
Member

lmoneta commented Sep 24, 2020

Hi,
It is strange that TH1::Integral(100,100) returns a different result than GetBinContent(100). I would need you to send me a root file containing the histogram

Lorenzo

@Dominic-Stafford
Copy link
Author

Dear Lorenzo

I tried to produce an example ROOT file containing a problematic histogram, however when I checked the histogram that caused the crash in the Combine program by reading it directly from the file, the Integral() method worked without a problem. I then assumed Combine had modified the histogram in some way that caused this behaviour, so I attempted using pdb to save the histogram directly after the the crash, however this histogram also seems well-behaved. I will comment again if I manage to get the issue in a slightly more reproducible form, as I appreciate this isn't possible to debug from your side.

@lmoneta
Copy link
Member

lmoneta commented Sep 28, 2020

Hi Dominic,
I close this issue for the time being. Please feel free to re-open it when you have a reproducible
Cheers
Lorenzo

@lmoneta lmoneta closed this as completed Sep 28, 2020
Triage automation moved this from Needs triage to Closed Sep 28, 2020
@hahnjo hahnjo added this to Issues in Fixed in: not applicable via automation Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants