Fix for duplicate active menu items. #986
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a duplication of active menu items when using custom post types. Namely that custom posts nested beneath a page cause the blog to become `.active` while simultaneously setting the parent page `.active` and the current menu item `.active`. This patch fixes all that nonsense. If you `print_r($classes); print_r($new_classes)` on line 60 you'll see that there are always at least 2 active replaces prior to the `array_unique($new_classes)`. The `array_search('current-menu-item',...` conditional check is to ensure that `.active` is still set for current menu item regardless of the number of `$new_class_counts`.
|
@Foxaii has a nav rejig branch that handles this which will be merged in soon |
|
Dang, wish I knew. His looks a lot fancier and probably more tested. This solved my problem in a down and dirty way. Feel free to close if you don't use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a duplication of active menu items when using custom post types. Namely that custom posts nested beneath a page cause the blog to become
.activewhile simultaneously setting the parent page.activeand the current menu item.active. This patch fixes all that nonsense. If youprint_r($classes); print_r($new_classes)on line 60 you'll see that there are always at least 2 active replaces prior to thearray_unique($new_classes). Thearray_search('current-menu-item',...conditional check is to ensure that.activeis still set for current menu item regardless of the number of$new_class_counts.