Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blade taxonomy template files with underscores not recognised #2447

Closed
4 tasks done
stuartcusackie opened this issue Apr 15, 2020 · 1 comment
Closed
4 tasks done
Labels
9.x Sage 9 related bug

Comments

@stuartcusackie
Copy link

stuartcusackie commented Apr 15, 2020

Description

If using underscores to name a custom taxonomy, e.g. 'digital_series' then blade templates using this naming convention won't be recognised.

A simple fix is to use hyphens instead, however, WordPress allows underscores in the naming of custom post types and taxonomies so I think this should be allowed in our blade files too.

This is now a problem for a live website of mine. We will have to figure out a way to rename our custom post types and taxonomies without losing data.

Steps to reproduce

  1. Create a custom taxonomy using underscore based naming convention, e.g. 'digital_series'

  2. Create a blade view for a custom taxonomy, e.g.: views/taxonomy-digital_series.blade.php - This is not recognised.

  3. Do the same without blade, e.g.: views/taxonomy-digital_series.php - This is recognised

Versions

Sage 9.0.7

@stuartcusackie stuartcusackie changed the title Taxonomy templates not working with Blade Taxonomy template files with blade extension not recognised Apr 15, 2020
@stuartcusackie stuartcusackie changed the title Taxonomy template files with blade extension not recognised Blade taxonomy template files with underscores not recognised Apr 15, 2020
@retlehs retlehs added the bug label May 16, 2020
@retlehs retlehs added the 9.x Sage 9 related label Aug 12, 2020
@Log1x
Copy link
Sponsor Member

Log1x commented Feb 16, 2021

This won't get fixed in Sage 9. If it's an issue in Sage 10 still, feel free to re-open.

@Log1x Log1x closed this as completed Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.x Sage 9 related bug
Projects
None yet
Development

No branches or pull requests

3 participants