Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require PHP extensions #40

Closed
LeoColomb opened this issue Jun 3, 2019 · 2 comments · Fixed by #41
Closed

Require PHP extensions #40

LeoColomb opened this issue Jun 3, 2019 · 2 comments · Fixed by #41

Comments

@LeoColomb
Copy link
Collaborator

Would be great to explicitly require PHP extensions used by WordPress in packages.

They are listed here: https://make.wordpress.org/hosting/handbook/handbook/server-environment/#php-extensions

No need to specify versions: https://getcomposer.org/doc/01-basic-usage.md#platform-packages

Ref: ItinerisLtd/wordpress-packager#15

@austinpray
Copy link
Contributor

👍

Just to be clear:

For instance ext-json is used extensively by WordPress. However: if this extension is missing WordPress includes a polyfill and everything still works fine. This means ext-json goes under the “suggest” key.

@austinpray
Copy link
Contributor

@tangrufus I merged #41

Seems backwards compatible and adds value. In the future we might need to check wordpress version and change suggestions based on new/removed deps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants