Skip to content
This repository has been archived by the owner on Jan 15, 2022. It is now read-only.

Include .DS_Store files in the .gitignore file of the files generated by rsgem #54

Closed
mrubi-rootstrap opened this issue Sep 17, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@mrubi-rootstrap
Copy link
Contributor

Is your feature request related to a problem? Please describe.

.DS_Store files are not ignored by git

Describe the solution you'd like

Add the line

.DS_Store

to the .gitignore file in the project generated by rsgem

@mrubi-rootstrap mrubi-rootstrap added the enhancement New feature or request label Sep 17, 2020
@juanmanuelramallo
Copy link
Contributor

Given this is a file exclusive to macOS (system dependent) I'd rather nudge macOS users to add .DS_Store to their global ~/.gitignore file, don't you think?

@mrubi-rootstrap
Copy link
Contributor Author

Yes, it makes sense but there's a catch.
I usually use /bin/bash a Docker container for some development tasks.
The Docker container usually has a git client of its own.
I try not to use git from the Docker container but sometimes I inadvertently do it.
Using a git config local to the project works out of the box for me even in those cases

@juanmanuelramallo
Copy link
Contributor

I guess it'd be better for the dockerfile to include the default .gitignore for the user. Otherwise we would be adding some OS-specific noise to rsgem IMHO. Closing it for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants