Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electrs txid_limit config is disabled causing queries to get stuck #1914

Closed
softsimon opened this issue Dec 31, 2020 · 7 comments
Closed

electrs txid_limit config is disabled causing queries to get stuck #1914

softsimon opened this issue Dec 31, 2020 · 7 comments
Milestone

Comments

@softsimon
Copy link

softsimon commented Dec 31, 2020

We are currently testing mempool explorer for Raspiblitz and there is an issue with the address page containing many transactions. The API call to electrum to fetch the txids (blockchainScripthash_getHistory), bitcoind get stuck with 100% cpu for hours because there's no limit... the default limit is actually 100 which is more reasonable, .. setting the limit to 1000 could work also .. and an error will be returned instead.

This is the default config on my raspiblitz 1.6.2

# allow BTC-RPC-explorer show tx-s for addresses with a history of more than 100
txid_limit = 0

From the romanz/electrs documentation:

doc = "Number of transactions to lookup before returning an error, to prevent 'too popular' addresses from causing the RPC server to get stuck (0 - disable the limit)"
default = "100"

@rootzoll rootzoll added this to the 1.6.3 Release milestone Jan 4, 2021
@rootzoll
Copy link
Collaborator

rootzoll commented Jan 4, 2021

For the v1.6.3 I will change the config to txid_limit = 1000 .. should we delay the v1.6.3 to include the new mempool explorer?

@wiz
Copy link
Contributor

wiz commented Jan 6, 2021

@rootzoll What was your timeline for the release? I think we shouldn't rush Simon too much, also it will take some time to work on the new build scripts and deployment environment, etc. - a lot has changed since v1

@rootzoll
Copy link
Collaborator

rootzoll commented Jan 6, 2021

@wiz after the weekend would be my latest target

@wiz
Copy link
Contributor

wiz commented Jan 6, 2021

Okay we will try to ship it this weekend

@rootzoll
Copy link
Collaborator

rootzoll commented Jan 10, 2021

@wiz keep me updated

  • include and test mempool update
  • set txid_limit = 1000

@wiz
Copy link
Contributor

wiz commented Jan 11, 2021

I've just started reviewing and testing Simon's PR to add bitcoind support mempool/mempool#281
After merging this, I can begin working on a PR to RaspiBlitz and the other Raspberry Pi distributions
It's already Monday here so I guess we won't ship it "this weekend" 😅

@rootzoll
Copy link
Collaborator

OK. new mempool version is merged. tests looking good :) closing issue for v1.6.3 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants