Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add REPAIR-LND menu to offer restore from file, seed+SCB and seed only #2832

Closed
openoms opened this issue Dec 20, 2021 · 8 comments
Closed
Milestone

Comments

@openoms
Copy link
Collaborator

openoms commented Dec 20, 2021

Currently testing

@rootzoll
Copy link
Collaborator

rootzoll commented Jan 4, 2022

OK the PR changed quite a lot because if the change to the new proto files. Because a test with a new sd card build is needed I merge it and then now it needs to be final tested on the following details:

  • new sd card build with merged PR - running?
  • recover with SEED for on-chain funds
  • recover with SEED & SCB for on-chain funds & closing channels (during setup & LND repair menu)
  • run/test Blitz TUI
  • run/test Wallet-Auto-Unlock (or change to new LND method)

@openoms openoms added the final testing was fixed - needs testing label Jan 16, 2022
@openoms
Copy link
Collaborator Author

openoms commented Jan 16, 2022

The route - REPAIR- LND - SEED+SCB has a problem - investigating
image

This was an easy fix: a1fe1ec

Run patch on the v1.7.2rc1d image to get the change.

@rootzoll
Copy link
Collaborator

rootzoll commented Jan 18, 2022

Needed to add the "scan recovery window" again to lnd unlock & iniwallet from seed to make lnd find the on-chain funds again.

@openoms
Copy link
Collaborator Author

openoms commented Jan 18, 2022

Needed to add the "scan recovery window" again to lnd unlock & iniwallet from seed to make lnd find the on-chain funds again.

It is there for the restore from seed: https://github.com/rootzoll/raspiblitz/blob/2ded9deb981cb0d374473dea7b098a185a8a6533/home.admin/99lndRepairMenu.sh#L440

and for seed+SCB: https://github.com/rootzoll/raspiblitz/blob/2ded9deb981cb0d374473dea7b098a185a8a6533/home.admin/99lndRepairMenu.sh#L269

@rootzoll
Copy link
Collaborator

rootzoll commented Jan 18, 2022

On setup the actual scan happens after the reboot and thats were the normal lnd cli based unlock is used

@openoms
Copy link
Collaborator Author

openoms commented Jan 18, 2022

That is right. The rescan is done if the REPAIR-LND menu is used (without restart).
If restoring with a fresh setup the rescan would need to be done manually from the menu after the initial setup and bitcoind sync.

If this is documented clearly might be enough or at least where I got to.

(This is also an issue for CL - the rescan there is fully manual, only documented in the FAQ.cl.md - could add some new logic there too)

@DocBrown101
Copy link

I have made one step forward but now I get a new error message:

WALLET --> UNLOCK WALLET - SCAN 0
WALLET --> SEED + SCB
lnd-wallet-seed+scb lnd.initwallet.py scb returned error /home/admin/config.scripts/lnd.initwallet.py scb mainnet ... --> the given filepathSCB - file does not exist or no permission +

Press ENTER to return to main menu.

@rootzoll
Copy link
Collaborator

The repair options got soem attention with this issue #2901 @DocBrown101 if you have some time best to wait for v1.7.2

@rootzoll rootzoll removed the final testing was fixed - needs testing label Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants