add the cln-grpc plugin #3109
add the cln-grpc plugin #3109
Conversation
| /home/bitcoin/${netprefix}cl-plugins-enabled/ | ||
| #blitz.conf.sh set [key] [value] [?conffile] <noquotes> | ||
| /home/admin/config.scripts/blitz.conf.sh set grpc-port "7777" ${CLCONF} noquotes | ||
| /home/admin/config.scripts/blitz.conf.sh set ${netprefix}cln-grpc-port "7777" |
There was a problem hiding this comment.
@rootzoll question: is there a benefit to use the port number here or should it be just
${netprefix}cln-grpc=on|off in the raspiblitz.conf and in redis?
Also the port number is completely arbitrary, suggestions are welcome.
For example on the 4*3 phone keyboard GRPC is 4772.
There was a problem hiding this comment.
I mean its nice to have the port numer as an option - the prestart script should take care of always setting it number. Only point is that its a bit more fuzzy as testing against "on" to check if the service shoudl be active. So now we would test if NOT "" - but that should be basically fine.
There was a problem hiding this comment.
port numbner 4772 sounds good with me - nice idea with the GRPC phonekeyboard coding :)
|
building the |
|
Please merge if you see this PR as done. Intense testing will be done as part of RC1 |
|
The cln-grpc plugin will be the part of the image release as it will be built after CLN in the build_sdcard.sh. Meging to |
releated #3054