Skip to content
This repository has been archived by the owner on May 10, 2022. It is now read-only.

characterise_data seems complicated... #8

Open
ellisp opened this issue Oct 26, 2017 · 2 comments
Open

characterise_data seems complicated... #8

ellisp opened this issue Oct 26, 2017 · 2 comments

Comments

@ellisp
Copy link
Collaborator

ellisp commented Oct 26, 2017

... and draws on global variables and other things. In combination with multi.sapply it just looks a bit complicated and maybe could be refactored to be easier to understand for future maintainers.

Currently this takes place in lines 23 to 51 of ./pkg/R/understanding_metadata.R

@HughParsonage
Copy link
Collaborator

I'm tempted to rewrite from scratch (won't remove it obviously). Do you think this is wise @ellisp ?

@ellisp
Copy link
Collaborator Author

ellisp commented Oct 27, 2017

Yes good idea

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants