use template for roles

[jospueyo]

@msperlin

The roles used in the code, as in "Conceptualization", "Methodology" and so on, should be defined in a single place. Do notice that you hard coded (wrote in a script) the roles in function create_template and in test test-read_template.

There are many ways to do it, but the simples is just using a function:

get_roles <- function() {

  roles <- c(
  "Conceptualization",
  "Methodology",
  "Software",
  "Validation",
  "Formal analysis",
  "Investigation",
  "Resources",
  "Data curation",
  "Writing - Original Draft",
  "Writing - Review & Editing",
  "Visualization",
  "Supervision",
  "Project administration",
  "Funding acquisition"
)

  return(roles)
}

With some simple webscrapping, you could use testthat to check if the template in the package is identical to the template from the site. Whenever the site adds or removes a role, your CHECK process will show it.

[jospueyo]

I added the functon roles_get() advancing the name convention suggested in the following issue. I also added a unit test that scraps CRediT and checks if roles are up-to-date. The test is skipped if rvest is not installed or if the tests are not run in local.