Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all vignette deps to DESCRIPTION #88

Closed
maelle opened this issue Jan 7, 2022 · 2 comments · Fixed by #89
Closed

Add all vignette deps to DESCRIPTION #88

maelle opened this issue Jan 7, 2022 · 2 comments · Fixed by #89

Comments

@maelle
Copy link
Member

maelle commented Jan 7, 2022

It seems e.g. viridis is missing, but there might be more? Thank you!

https://github.com/r-universe/ropensci/runs/4691817799?check_suite_focus=true

Reading 'vignettes/articles/visualize_nlms.Rmd'
-- RMarkdown error -------------------------------------------------------------
Scale for 'fill' is already present. Adding another scale for 'fill', which
will replace the existing scale.
Loading required package: lattice
Loading required package: sp
Quitting from lines 148-160 (visualize_nlms.Rmd) 
Error in library("viridis") : there is no package called 'viridis'
In addition: Warning messages:
1: `guides(<scale> = FALSE)` is deprecated. Please use `guides(<scale> = "none")` instead. 
2: In nlm_mpd(ncol = 50, nrow = 50, roughness = 0.6) :
  nlm_mpd changes the dimensions of the RasterLayer if even ncols/nrows are choosen.
--------------------------------------------------------------------------------
Error : Failed to render RMarkdown

@marcosci

@marcosci
Copy link
Collaborator

marcosci commented Jan 7, 2022

Sorry, very busy months. Now again ahead of things and trying to fix this.

97c8df6 ... does this fix things? :) Don't know if I can trigger a rebuild ropensci universe and check this myself ... a bit out of the package maintaining game 😅

@maelle
Copy link
Member Author

maelle commented Jan 7, 2022

The build will trigger itself with the commit, hourly IIRC. I'll re-check https://ropensci.r-universe.dev/ui#builds later today

Thank you! I can make a PR next week if it wasn't enough, happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants