Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure clear structure for users of allo-db to modify allometric equation choices #60

Closed
teixeirak opened this issue Oct 18, 2018 · 5 comments

Comments

@teixeirak
Copy link
Member

It will be important to work out a clear mechanism for advanced users of allo-db to modify choices of allometric equations. This could be done permanently, with approval of allo-db managers, through alteration of the master sites-species table (e.g., if a site PI identifies a more appropriate equation). However, I'm not sure we have a mechanism for temporary modification (e.g., if someone wants to compare results of using different equations). @maurolepore, can you please find a way to make this possible through the code?

@maurolepore
Copy link
Member

I'm not sure we have a mechanism for temporary modification (e.g., if someone wants to compare results of using different equations). @maurolepore, can you please find a way to make this possible through the code?

I'll keep this in mind. For every decision the code does we can let users overwrite the default. Stuart and I touched on this topic yesterday. He wanted to know more about where the Wood Density Data was coming from and how a user could change that. Using that as an example, the code could use whatever table allodb provides, but allow the user to use a custom table instead.

@maurolepore
Copy link
Member

It will be important to work out a clear mechanism for advanced users of allo-db to modify choices of allometric equations. This could be done permanently, with approval of allo-db managers, through alteration of the master sites-species table (e.g., if a site PI identifies a more appropriate equation).

Users can now choose a focused issue to propose a more appropriate equation at https://github.com/forestgeo/allodb/issues/new/choose

This issue will be automatically assigned to @gonzalezeb and @teixeirak, and will be labeled as 'enhancement'. You can edit/create template at https://github.com/forestgeo/allodb/issues/templates/edit

@teixeirak
Copy link
Member Author

Thanks for setting this up! I'll let @gonzalezeb set up the template-- should be simple, but we need to make sure it includes all the necessary info to populate the table.

@maurolepore
Copy link
Member

maurolepore commented Feb 22, 2019

I'm not sure we have a mechanism for temporary modification (e.g., if someone wants to compare results of using different equations). @maurolepore, can you please find a way to make this possible through the code?

allo_find() gains the argument custom_eqn. Defaults to using default equations (i.e. custom_eqn = NULL).

@gonzalezeb
Copy link
Contributor

This idea is somehow covered by the new_equations function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants