Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle more functions per file #42

Closed
richelbilderbeek opened this issue Jul 21, 2018 · 0 comments
Closed

Bundle more functions per file #42

richelbilderbeek opened this issue Jul 21, 2018 · 0 comments

Comments

@richelbilderbeek
Copy link
Member

Feedback bjoelle:

I think this package contains too many files, many of which contain only one small function. Gathering functions which are strongly linked to each other (for instance, are_site_models, is_site_model, is_site_model_name and get_site_model_names) in one file would make the package easier to read and search in my opinion.

@richelbilderbeek richelbilderbeek added this to To do in Process rOpenSci feedback via automation Jul 21, 2018
@richelbilderbeek richelbilderbeek moved this from To do to To be checked by Travis CI in Process rOpenSci feedback Sep 22, 2018
Process rOpenSci feedback automation moved this from To be checked by Travis CI to Done Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

1 participant