Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor clock_models_to_xml to avoid duplication #55

Closed
richelbilderbeek opened this issue Jul 21, 2018 · 1 comment
Closed

Refactor clock_models_to_xml to avoid duplication #55

richelbilderbeek opened this issue Jul 21, 2018 · 1 comment
Projects
Process rOpenSci feedback

Comments

@richelbilderbeek
Copy link
Member

Feedback bjoelle:

all the functions clock_models_to_xml start by calling get_unlinked_clock_models. This call could be placed earlier (create_beast2_input_run is my suggestion) which would save the repetition.
@richelbilderbeek richelbilderbeek mentioned this issue Jul 21, 2018
Closed
@richelbilderbeek richelbilderbeek added this to To do in Process rOpenSci feedback via automation Jul 21, 2018
@richelbilderbeek
Copy link
Member Author

bjoelle has spotted this well.

But it must be there: the tests of clock_models_to_xml_* now test a naturally sized chunk of XML.

To keep the modularity of the clock_models_to_xml_* functions, I will keep the duplications.

Process rOpenSci feedback automation moved this from To do to Done Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Process rOpenSci feedback
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@richelbilderbeek