Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not modify globals #72

Closed
richelbilderbeek opened this issue Jul 21, 2018 · 0 comments
Closed

Do not modify globals #72

richelbilderbeek opened this issue Jul 21, 2018 · 0 comments
Assignees
@richelbilderbeek
Projects
Process rOpenSci feedback

Comments

@richelbilderbeek
Copy link
Member

Feedback dwinter:

The function create_beast2_input sets the user's global scipen option. It's not clear from the code exactly where this value is needed, but it would seem a better idea to either store the existing value (old_scipen <- getOption("scipen")) then ensure the value is reset using on.exit.
@richelbilderbeek richelbilderbeek mentioned this issue Jul 21, 2018
Closed
@richelbilderbeek richelbilderbeek moved this from In progress to To do in Process rOpenSci feedback Jul 21, 2018
@richelbilderbeek richelbilderbeek moved this from To do to To be checked by Travis CI in Process rOpenSci feedback Jul 21, 2018
Process rOpenSci feedback automation moved this from To be checked by Travis CI to Done Jul 21, 2018
@richelbilderbeek richelbilderbeek self-assigned this Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richelbilderbeek richelbilderbeek

Labels
None yet
Projects
No open projects
Process rOpenSci feedback
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@richelbilderbeek