-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
London dates not parsed correctly in bike_daily_trips() #85
Comments
Thanks for that - the whole package recently got restructured to do more intelligent auto-parsing of dates, but I'm now reliant on people directly finding these kinds of inconsistencies. It should be relatively straightforward to fix, so I'll get on to it asap. |
Actually seems okay. Can you make sure you have the latest version:
|
oh sorry, just noticed you got the error from |
Sorry, misunderstood the problem myself there for a while. You were right: the dates for London weren't being processed properly at all. That PR should now fix it, and |
It seems that London files in the csv or Excel sheets are dated Day / Month / Year, instead of Month / Day / Year as it's seen in other cities. It seems that
bike_daily_trips()
expects the dates to be the latter, resulting in erroneous dates parsing, as well as a huge amount ofNA
s. I haven't checked other functions, but I expect the issue to be present throughout.In case it helps, I've run the following after downloading the files I needed to bring in the CSV files, change their date format, and save back to disk:
The text was updated successfully, but these errors were encountered: