Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail #31

Open
adamhsparks opened this issue Aug 29, 2021 · 3 comments
Open

Tests fail #31

adamhsparks opened this issue Aug 29, 2021 · 3 comments
Assignees

Comments

@adamhsparks
Copy link
Member

I was troubleshooting some of the tests when I found discrepancies in the precip indices.

This is from

test_that("default method", {

> x
 [1]  0.00  0.00  0.00  0.00 20.18 38.35  0.00 38.35  0.00  0.00
> chirps$chirps
 [1]  9.26  0.00  0.00  0.00 18.51 38.35  0.00 38.35  0.00  0.00

I didn't go further as it's getting late here. Just flagging this to follow up later.

@kauedesousa kauedesousa self-assigned this Aug 31, 2021
@kauedesousa
Copy link
Member

Thanks @adamhsparks I am in the middle of other tasks but I will take a look asap

K

@adamhsparks
Copy link
Member Author

No worries. I didn't mean to hurry you. Just flagging this so we're aware.

@adamhsparks
Copy link
Member Author

I've done quite a bit of work on the tests in the devel branch. I've isolated some of the issues with vcr cassettes thanks to @maelle. I'm adding more tests for some of the uncovered functionality as well.

@adamhsparks adamhsparks self-assigned this Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants