Update ds_create method to properly format body with json data #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d with record sending
|
thanks for this @mattfullerton When is a good time for you to have call? |
|
What timezone are you in? I am UTC+1 (Europe). Mornings are usually free, next Wednesday for example. Maybe further discussion over email (https://github.com/mattfullerton)? |
|
thanks for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request brings the ds_create method to the point where it can insert records in the datastore resource.
@sckott I may have the chance to work a lot with this at the moment and would be up for filling in the gaps in and documenting the Datastore API. As I am not an R expert it might help me a lot if we could talk for 15m sometime to get a crash course on HTTP calls in R, package conventions, etc.