Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clifro Error in function #27

Closed
Lahi-H opened this issue Nov 17, 2020 · 10 comments
Closed

Clifro Error in function #27

Lahi-H opened this issue Nov 17, 2020 · 10 comments

Comments

@Lahi-H
Copy link

Lahi-H commented Nov 17, 2020

I cant seem to get past the errors below. Any advice would be very much appreciated.

Error

@blasee blasee closed this as completed in a7b84f8 Dec 31, 2020
@blasee
Copy link
Contributor

blasee commented Dec 31, 2020

Hi @Lahi-H,

Thanks for submitting this bug report! This should have been fixed with the latest development version of clifro. The following lines of code should now be working as expected:

remotes::install_github("ropensci/clifro")
library(clifro)

# Make sure you're using the dev version
packageVersion("clifro")        # 3.2.3.9000

all.auckland.st = cf_find_station("auckland", search = "region", status = "all")

daily.wind.rain.dt = cf_datatype(c(2,3), c(1,1), list(4,1), c(1, NA))

reefton.st = cf_station()

Feel free to reopen this if you encounter the same error.

Thanks,
Blake

@Lahi-H
Copy link
Author

Lahi-H commented Dec 31, 2020

Any time . Thank you very much.

@Lahi-H Lahi-H changed the title Clifro Error in function Clifro Error in function re Jan 13, 2021
@Lahi-H
Copy link
Author

Lahi-H commented Jan 13, 2021

@blasee
my GitHub knowledge isn't that great so not sure if it reopened
but I am still having this issue.
error issue

@Lahi-H Lahi-H changed the title Clifro Error in function re Clifro Error in function Jan 13, 2021
@blasee
Copy link
Contributor

blasee commented Jan 14, 2021

Hi @Lahi-H,

Thanks for testing. Can you please provide the output from the functions below:

cf_user("public")
cf_datatype(3, 1, 1)
cf_station()
sessionInfo()

Thanks,
Blake

@Lahi-H
Copy link
Author

Lahi-H commented Jan 14, 2021

@blasee
Here is the output for
cf_user("public")
cf_datatype(3, 1, 1)
cf_station()
sessionInfo()

error issue2

@blasee
Copy link
Contributor

blasee commented Jan 14, 2021

Thanks @Lahi-H,

I can't seem to reproduce this error on Linux or Windows, but it would appear that the error is coming from the cf_station() function. Can you please give the output for the following:

cf_station()
traceback()

@Lahi-H
Copy link
Author

Lahi-H commented Jan 14, 2021

@blasee
here it is sorry for late reply
error issue3

@blasee
Copy link
Contributor

blasee commented Jan 18, 2021

Hi @Lahi-H,

I've made some minor changes to the cf_station() function that I'm hoping will fix the error you're getting. Thanks for helping with this! Can you please check your code again with the latest development version of clifro:

remotes::install_github("ropensci/clifro")
library(clifro)

# Make sure you're using the dev version
packageVersion("clifro")        # 3.2-4.9000

all.auckland.st = cf_find_station("auckland", search = "region", status = "all")

daily.wind.rain.dt = cf_datatype(c(2,3), c(1,1), list(4,1), c(1, NA))

reefton.st = cf_station()

@Lahi-H
Copy link
Author

Lahi-H commented Feb 2, 2021

it works thanks. just a quick question.
is there a way to only get NZST time for the cf_query ?
cause tz = "NZST" doesnt work.

@blasee
Copy link
Contributor

blasee commented Mar 18, 2021

Hi @Lahi-H,

The tz argument refers to the timezone of the specified start_date and end_date arguments. The output timezone is always NZ local time in clifro. At the moment you will have to convert to another timezone after the clifro query. Thanks for your comment, I'll implement this feature in the upcoming version of clifro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants