Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retry method: Handle dates given in Retry-After headers #96

Open
sckott opened this issue Dec 5, 2018 · 1 comment
Open

retry method: Handle dates given in Retry-After headers #96

sckott opened this issue Dec 5, 2018 · 1 comment

Comments

@sckott
Copy link
Collaborator

sckott commented Dec 5, 2018

via #95

this shouldn't happen very often but can happen apparently

as.numeric() does not fail, but instead throws a warning.

as.numeric('2018-12-05T00:00:00.000Z')
[1] NA
Warning message:
NAs introduced by coercion

we can tryCatch this perhaps or look for a date in the string and handle accordingly
@sckott sckott changed the title Handle dates given in Retry-After headers retry method: Handle dates given in Retry-After headers Dec 5, 2018
@sckott sckott mentioned this issue Dec 5, 2018
Merged
@sckott sckott added this to the v0.8 milestone Dec 27, 2018
@sckott sckott modified the milestones: v0.7.4, v0.8 Mar 22, 2019
@sckott sckott removed this from the v0.8 milestone Jun 27, 2019
@sckott
Copy link
Collaborator Author

sckott commented Jun 27, 2019

removing v0.8 milestone for now - will incorporate a test once we have a real world use case of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sckott