Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase guardrails on file_out() and knitr_in() #1229

Closed
2 tasks done
wlandau opened this issue Mar 23, 2020 · 1 comment
Closed
2 tasks done

Increase guardrails on file_out() and knitr_in() #1229

wlandau opened this issue Mar 23, 2020 · 1 comment
Labels
status: priority topic: api topic: reproducibility

Comments

@wlandau
Copy link
Collaborator

wlandau commented Mar 23, 2020 •
edited

Prework

Description

file_out() and knitr_in() should not be used inside imported functions, and they should not be used in dynamic branching. drake should make both impossible, and the errors should be informative.
@wlandau-lilly
Copy link
Collaborator

Let's also throw warnings if people try to use dynamic paths, e.g. file_in(paste(var, ".html"))

@wlandau-lilly wlandau-lilly mentioned this issue Mar 23, 2020
Closed
@wlandau wlandau mentioned this issue Mar 23, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: priority topic: api topic: reproducibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wlandau @wlandau-lilly