You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Wildcard functions. In functions like evaluate_plan(), we should deparse the command column, do the text replacement, safe_parse() to get language objects, and then restore the S3 class.
Command standardization. I think this part will clean up and speed up nicely. We just need to remember to use all.vars(functions = TRUE) instead of grepl() to set look_for_ignore in standardize_command().
The text was updated successfully, but these errors were encountered:
Using a new_tibble(subclass = "drake_plan") with custom printing actually seems to work. In the 700 branch, drake deparses list columns of language objects and then overloads pillar::type_sum() to show <lang> instead of <chr> when printing. Deparsing should not be a bottleneck because it happens after the rows are subsetted.
Now, I need to update the wildcard functions and the tests. Could take some time.
Printing seems to work out okay now. Note the <expr> type summary below. Hopefully the deparsing is not too slow. I have not yet decided whether to skip most of the deparsing or how best to do that.
drake
currently uses character strings to represent code.Now that we have a language-based DSL (#233) we can start to move away from text. Specific considerations:
print()
method fordrake
plans. The trouble is that data frame operations often drop attributes.evaluate_plan()
, we should deparse thecommand
column, do the text replacement,safe_parse()
to get language objects, and then restore the S3 class.all.vars(functions = TRUE)
instead ofgrepl()
to setlook_for_ignore
instandardize_command()
.The text was updated successfully, but these errors were encountered: