Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drake 7.1.0 is repeating messages and errors arising during plan execution #829

Closed
MilesMcBain opened this issue Apr 9, 2019 · 1 comment
Assignees

Comments

@MilesMcBain
Copy link
Contributor

Description

When calling make or r_make messages arising during plan execution are output to console twice. This is new since 7.1.0, see 7.0.0 reprex below.

Reproducible example

7.1.0

library(readr)
library(drake)
packageVersion('drake')
#> [1] '7.1.0'
tt_plan <-
  drake_plan(
    version = packageVersion('drake'),

    player_dob = read_csv("https://raw.githubusercontent.com/rfordatascience/tidytuesday/master/data/2019/2019-04-09/player_dob.csv")
    )
make(tt_plan)
#> target version
#> target player_dob
#> Parsed with column specification:
#> cols(
#>   name = col_character(),
#>   grand_slam = col_character(),
#>   date_of_birth = col_date(format = ""),
#>   date_of_first_title = col_date(format = ""),
#>   age = col_double()
#> )
#> Target player_dob messages:
#>   Parsed with column specification:
#> cols(
#>   name = col_character(),
#>   grand_slam = col_character(),
#>   date_of_birth = col_date(format = ""),
#>   date_of_first_title = col_date(format = ""),
#>   age = col_double()
#> )

sessionInfo()
#> R version 3.5.3 (2019-03-11)
#> Platform: x86_64-pc-linux-gnu (64-bit)
#> Running under: Debian GNU/Linux 9 (stretch)
#> 
#> Matrix products: default
#> BLAS: /usr/lib/openblas-base/libblas.so.3
#> LAPACK: /usr/lib/libopenblasp-r0.2.19.so
#> 
#> locale:
#>  [1] LC_CTYPE=en_AU.UTF-8       LC_NUMERIC=C              
#>  [3] LC_TIME=en_AU.UTF-8        LC_COLLATE=en_AU.UTF-8    
#>  [5] LC_MONETARY=en_AU.UTF-8    LC_MESSAGES=en_AU.UTF-8   
#>  [7] LC_PAPER=en_AU.UTF-8       LC_NAME=C                 
#>  [9] LC_ADDRESS=C               LC_TELEPHONE=C            
#> [11] LC_MEASUREMENT=en_AU.UTF-8 LC_IDENTIFICATION=C       
#> 
#> attached base packages:
#> [1] stats     graphics  grDevices utils     datasets  methods   base     
#> 
#> other attached packages:
#> [1] drake_7.1.0 readr_1.3.1
#> 
#> loaded via a namespace (and not attached):
#>  [1] igraph_1.2.4     Rcpp_1.0.1       knitr_1.22       magrittr_1.5    
#>  [5] hms_0.4.2        R6_2.4.0         rlang_0.3.1.9000 stringr_1.4.0   
#>  [9] highr_0.8        storr_1.2.1      tools_3.5.3      xfun_0.5        
#> [13] cli_1.1.0        htmltools_0.3.6  assertthat_0.2.1 base64url_1.4   
#> [17] yaml_2.2.0       digest_0.6.18    tibble_2.1.1     crayon_1.3.4    
#> [21] curl_3.3         evaluate_0.13    rmarkdown_1.12   stringi_1.4.3   
#> [25] compiler_3.5.3   pillar_1.3.1     backports_1.1.3  lubridate_1.7.4 
#> [29] pkgconfig_2.0.2

Created on 2019-04-09 by the reprex package (v0.2.1)

7.0.0

library(readr)
library(drake)
packageVersion('drake')
#> [1] '7.0.0'
tt_plan <-
  drake_plan(
    version = packageVersion('drake'),

    player_dob = read_csv("https://raw.githubusercontent.com/rfordatascience/tidytuesday/master/data/2019/2019-04-09/player_dob.csv")
    )
make(tt_plan)
#> target version
#> target player_dob
#> Target player_dob messages:
#>   Parsed with column specification:
#> cols(
#>   name = col_character(),
#>   grand_slam = col_character(),
#>   date_of_birth = col_date(format = ""),
#>   date_of_first_title = col_date(format = ""),
#>   age = col_double()
#> )

sessionInfo()
#> R version 3.5.3 (2019-03-11)
#> Platform: x86_64-pc-linux-gnu (64-bit)
#> Running under: Debian GNU/Linux 9 (stretch)
#> 
#> Matrix products: default
#> BLAS: /usr/lib/openblas-base/libblas.so.3
#> LAPACK: /usr/lib/libopenblasp-r0.2.19.so
#> 
#> locale:
#>  [1] LC_CTYPE=en_AU.UTF-8       LC_NUMERIC=C              
#>  [3] LC_TIME=en_AU.UTF-8        LC_COLLATE=en_AU.UTF-8    
#>  [5] LC_MONETARY=en_AU.UTF-8    LC_MESSAGES=en_AU.UTF-8   
#>  [7] LC_PAPER=en_AU.UTF-8       LC_NAME=C                 
#>  [9] LC_ADDRESS=C               LC_TELEPHONE=C            
#> [11] LC_MEASUREMENT=en_AU.UTF-8 LC_IDENTIFICATION=C       
#> 
#> attached base packages:
#> [1] stats     graphics  grDevices utils     datasets  methods   base     
#> 
#> other attached packages:
#> [1] drake_7.0.0 readr_1.3.1
#> 
#> loaded via a namespace (and not attached):
#>  [1] igraph_1.2.4     Rcpp_1.0.1       knitr_1.22       magrittr_1.5    
#>  [5] hms_0.4.2        R6_2.4.0         rlang_0.3.1.9000 stringr_1.4.0   
#>  [9] highr_0.8        storr_1.2.1      tools_3.5.3      xfun_0.5        
#> [13] htmltools_0.3.6  base64url_1.4    yaml_2.2.0       digest_0.6.18   
#> [17] tibble_2.1.1     crayon_1.3.4     curl_3.3         evaluate_0.13   
#> [21] rmarkdown_1.12   stringi_1.4.3    compiler_3.5.3   pillar_1.3.1    
#> [25] backports_1.1.3  pkgconfig_2.0.2

Created on 2019-04-09 by the reprex package (v0.2.1)

Expected output

As per the 7.0.0 reprex.

@MilesMcBain MilesMcBain changed the title Drake 7.0.1 is repeating messages and errors arising during plan execution Drake 7.1.0 is repeating messages and errors arising during plan execution Apr 9, 2019
@wlandau
Copy link
Collaborator

wlandau commented Apr 9, 2019

Yeah, sorry about that. Now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants