Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set_responsibleParty(): allow to create organization parties #345

Closed
peterdesmet opened this issue Jun 3, 2022 · 1 comment · Fixed by #346
Closed

set_responsibleParty(): allow to create organization parties #345

peterdesmet opened this issue Jun 3, 2022 · 1 comment · Fixed by #346
Assignees
Labels

Comments

@peterdesmet
Copy link
Member

According the documentation, it should be possible to create a party that is not a person:

organizationName: if party is an organization instead of an individual, name for the org

However, when set_responsibleParty() is not provided a givenName argument, it returns an error:

library(EML)
  set_responsibleParty(organizationName = "INBO", onlineUrl = "https://inbo.be")
#> Error in UseMethod("set_responsibleParty", givenName): no applicable method for 'set_responsibleParty' applied to an object of class "NULL"

Created on 2022-06-03 by the reprex package (v2.0.1)

amoeba added a commit that referenced this issue Jun 6, 2022
Closes #345

Previously, passing only the organization argument would error out because UseMethod was dispatching on givenName which is NULL in the case of creating an organization.
@amoeba amoeba self-assigned this Jun 6, 2022
@amoeba amoeba added the bug label Jun 6, 2022
@amoeba
Copy link
Collaborator

amoeba commented Jun 6, 2022

Thanks for the report @peterdesmet, I agree this needs fixing. I've sent in a PR which either I or another on the team will merge soon to address this. I'll close this once that's merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants