Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on geojsonlint #44

Closed
maelle opened this issue May 11, 2023 · 10 comments
Closed

Remove dependency on geojsonlint #44

maelle opened this issue May 11, 2023 · 10 comments

Comments

@maelle
Copy link
Member

maelle commented May 11, 2023

As it hasn't found a new maintainer (yet), sorry about that.

I see it's used in docs and tests: https://github.com/search?q=repo%3Aropensci%2Fgeojson%20geojsonlint&type=code

Cc @mdsumner

@maelle
Copy link
Member Author

maelle commented Jul 18, 2023

@mdsumner I'll have to archive geojsonlint as it hasn't found a new maintainer, could you please remove it from geojson dependencies? I'm sorry.

@mdsumner
Copy link
Contributor

ok!

@mdsumner
Copy link
Contributor

what if I take on geojsonlint too? but, seems like a fairly soft removal

I'll explore

@mdsumner
Copy link
Contributor

mdsumner commented Jul 18, 2023

@sckott can you inform cran I'll take over geojson? with mdsumner gmail 🙏

I'll make sure revdeps.are ok and that there's no issues from removing geojsonlint here, and issue an update 🙏 then I can explore later pathways

@maelle
Copy link
Member Author

maelle commented Jul 18, 2023

what if I take on geojsonlint too? but, seems like a fairly soft removal

As you prefer, but really don't feel like you have to.

Thanks so much!

@mdsumner mdsumner changed the title Remove dependency on geojsonlit Remove dependency on geojsonlint Jul 18, 2023
@sckott
Copy link
Contributor

sckott commented Jul 18, 2023

i've always done it the other way - you submit to cran with the email/name change, then they email me and ask to approve, bueno ?

@mdsumner
Copy link
Contributor

ok!

@mdsumner
Copy link
Contributor

removed geojsonlint, CRAN have been emailed and they're expecting a submit

@maelle
Copy link
Member Author

maelle commented Jul 25, 2023

In a few weeks then, correct? @mdsumner

Thanks a lot in any case!

@mdsumner
Copy link
Contributor

mdsumner commented Jul 25, 2023

yes lol sorry missed the holidays call ... have no idea here in our sunny cold depths of winter 😅

I've set a reminder 👌 btw I'm happy to be prompted more, I know it's a burden to chase people but atm I can definitely take on a few more of these projects that need it so I'm a good target 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants