Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.Rmd on GH front page #74

Closed
gaborcsardi opened this issue Sep 14, 2014 · 6 comments
Closed

README.Rmd on GH front page #74

gaborcsardi opened this issue Sep 14, 2014 · 6 comments

Comments

@gaborcsardi
Copy link
Contributor

It seems that now Github shows README.Rmd before README.md, which is sometimes good, but if you want to show the R output (and hide knitr config), then it is probably not.

I suggest moving README.Rmd to vignettes/, and leaving README.md at its current place. And of course updating the Makefile accordingly. If this is fine, I can send a pull request, of course.

@karthik
Copy link
Member

karthik commented Sep 14, 2014

I pushed for this change. But I've also filed a issue to get this fixed. Hopefully early next week.

github/markup#360

@karthik
Copy link
Member

karthik commented Sep 14, 2014

I suggest moving README.Rmd to vignettes/, and leaving README.md at its current place. And of course updating the Makefile accordingly. If this is fine, I can send a pull request, of course.

But I do second @gaborcsardi's suggestion until the fix is pushed through.

@stewid
Copy link
Member

stewid commented Sep 14, 2014

I also second @gaborcsardi's suggestion to use README.md

It was reported problematic to install with a vignette in issue #14

I tried to install git2r today on Windows 8.1
The package vignette does not build on Windows, so I can only install by using
install_github("git2r", "ropensci", build_vignettes=FALSE)

I removed the vignette to solve the issue. Maybe we can just drop README.Rmd for now?

@stewid
Copy link
Member

stewid commented Sep 15, 2014

I dropped README.Rmd

@stewid stewid closed this as completed Sep 19, 2014
@karthik
Copy link
Member

karthik commented Sep 19, 2014

But just for future ref, GitHub did fix the rendering order. Rmd and rmd will now always render after the md.

@stewid
Copy link
Member

stewid commented Sep 19, 2014

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants