Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo/Task View Name? #10

Closed
jhollist opened this issue Feb 6, 2015 · 18 comments
Closed

Repo/Task View Name? #10

jhollist opened this issue Feb 6, 2015 · 18 comments

Comments

@jhollist
Copy link
Member

jhollist commented Feb 6, 2015

Was wondering if this was the best name for a task view, given that it is also the name of package?

Perhaps just simply "Mapping" or "Mapping and Cartography" or "Spatial Data Visualization"?

Thoughts?

@sckott
Copy link
Contributor

sckott commented Feb 6, 2015

perhaps yeah, it was already changed from mappingtools i think #5 - maybe stay away from Spatial since there's already a task view named Spatial

@jhollist
Copy link
Member Author

jhollist commented Feb 6, 2015

Perhaps simple is best? "Mapping"?

I can update the files and may start to add in some other stuff from the issues. Won't be able to complete it but can at least get a start. I'll try to submit a PR in a bit.

@jhollist
Copy link
Member Author

jhollist commented Feb 6, 2015

Actually looking at this more (my first time playing with ctv), Is it just the MapTools.ctv, makefile, and whiskerit.R that would need updating?

@sckott
Copy link
Contributor

sckott commented Feb 6, 2015

just edit https://github.com/ropensci/maptools/blob/master/tools.ctv then run make in the repo, or just edit https://github.com/ropensci/maptools/blob/master/tools.ctv and push, then we can compile the changes, the makefile is pretty hacky, sorry

@jhollist
Copy link
Member Author

jhollist commented Feb 6, 2015

Ah... I tried to figure it out and lost my changes (not many)...

Done for the night, but may try to get some changes done and pushed tomorrow.

@sckott
Copy link
Contributor

sckott commented Feb 6, 2015

@jhollist k, will wait for your changes

@jhollist
Copy link
Member Author

jhollist commented Feb 6, 2015

@sckott , got some changes up on my fork. Need to look through them some more before PR. Decided to hold off on any name change stuff mainly because I am not sure what all should be changed... Maybe tonight for PR?

@sckott
Copy link
Contributor

sckott commented Feb 6, 2015

sure, sounds good

@karthik
Copy link
Member

karthik commented Feb 6, 2015

@jhollist Would you like to join us as an official maintainer?

@jhollist
Copy link
Member Author

jhollist commented Feb 6, 2015

@karthik Sure. I haven't worked with the task views prior to this so might need a bit of guidance at first.

What is the workload like? I would imagine some up front then a little here and there updating after the first version is complete.

@karthik
Copy link
Member

karthik commented Feb 6, 2015

@jhollist There will some effort to get this going, but once you pushed the first version, I believe you'll just have maintenance to do from time to time. If you follow the CRANberries twitter account, you'll see new R packages there. If anything sounds mappy, check it out and add it to the issues. One of the maintainers will add it when they find time. There is no pressing need to keep it updated in realtime.
@sckott can say more since he does all of the work on the other taskview.

@sckott
Copy link
Contributor

sckott commented Feb 6, 2015

@jhollist it's sort of up to you how much you want to do. the web tech view is a group effort, mostly Leeper and I - once we had the workflow down of going from entering new things to making the readme to making the final ctv, its not much work.

you do need to use svn instead of git to submit each update

I have a kind of complicated setup in web tech cause I wanted deep links to each subject area in the github readme, and then I need to manually remove stuff before sending to cran, but that's up to you.

probably good not to overlap with the Spatial task view http://cran.r-project.org/web/views/Spatial.html

@jhollist
Copy link
Member Author

jhollist commented Feb 7, 2015

Thanks guys.

I imagine I won't mess much with the workflow you have set up in the makefile, @sckott . Perhaps down the line but certainly not as I learn the ropes. Once we have something pulled together that is ready to push I'll need a bit of help with the svn side of things. Have only use git.

And I agree on limiting the overlap with Spatial. There will be some (rgdal comes to mind), but for the most part I think we can keep them separate.

Thanks for letting me help with this. Looking forward to contributing!

@sckott
Copy link
Contributor

sckott commented Feb 7, 2015

@jhollist 🚀

@jhollist
Copy link
Member Author

jhollist commented Feb 7, 2015

Last question, then I'll close this issue. Name change can wait.

Any guidance on best workflow for this?

  1. Keep working on my fork and submit PRs and have you guys accept those?
  2. Keep working on my fork and submit PRs, I get push rights and I accept the PRs (probably what I would guess is the best)
  3. I get push rights and push directly.

As for branch to work on, what is best? I work on github mostly solo and haven't been using branches much, so advice gladly accepted!

@jhollist jhollist closed this as completed Feb 7, 2015
@karthik
Copy link
Member

karthik commented Feb 7, 2015

I'll add you to a team with admin access. So just pull this repo down (no fork necessary) and either push directly if you feel comfortable or push a branch and do a PR. You can merge those yourself or ask one of us to look over before merging.

@jhollist
Copy link
Member Author

jhollist commented Feb 7, 2015

@karthik Sounds good. Thanks

@jsta
Copy link

jsta commented Mar 14, 2017

Any more thoughts on a possible name change? Just landed here searching for the maptools package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants