New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geoparser: geoparsing with the geoparser.io API #43
Comments
Thanks for your submission @masalmon Seeking reviewers now |
Reviewers: @hrbrmstr |
@hrbrmstr |
@hrbrmstr |
@hrbrmstr |
on it now (apologies) |
thx |
Package Name
Function/variable Naming
README
Code of Conduct
Documentation
Authorship
Testing
Versioning
Continuous integration
Examples
Package dependencies
DESCRIPTION format
Recommended scaffolding
Console messages
CRAN Check Issues
General Review
Other Suggestions
Review time: ~2.5 hours (I forgot to clock myself earlier today) |
Thank you so much, @hrbrmstr! I look forward to making all the suggested changes! 😸 |
Thanks for the thorough review @hrbrmstr. |
I don't think you owed me the PR, @hrbrmstr so many thanks! It really was useful! I have learnt a lot. 👍 Reg.: "Nice use of the "standard"/modern R way to access APIs requring an API key." At least part of it is my copy-pasting the function @noamross had added to
I'm going to summarize what I did:
Once you all (@hrbrmstr, @noamross & @sckott ) will be happy with the package, I'll transfer the repo to ropenscilabs but also submit it to CRAN. I had discussed the possible API changes with geoparser.io and I think it's ok to submit this version. I have added the API version number to DESCRIPTION. |
aye. i also re-looked at the code and it's #spiffy. On Thu, Jun 16, 2016 at 11:10 AM, Noam Ross notifications@github.com
|
Thank you @hrbrmstr. I have done an editors' check and you are approved! Please go ahead and transfer the repository to |
Awesome, many thanks to you both, I'll do this ASAP! |
Transfer done. Next step will be the CRAN submission! |
This package is an interface to the geoparser.io API that identifies places mentioned in text, disambiguates those places, and returns data about the places found in the text.
https://github.com/masalmon/geoparser
The geoparser.io API which is version beta. They said "We expect it to remain largely the same for the immediate future. We'd try to make any changes backwards compatible, and support older versions of the API for an extended period of time to allow users to migrate at their convenience. However, the most likely things to change are:
People interested in Natural Language Processing, or anyone with text where they would like to identify geographical information.
I don't think so. Named Entity Recognition (including placenames) in R is currently offered by the openNLP package that requires Java but then the results are not geolocated.
devtools
install instructionsdevtools::check()
produce any errors or warnings? If so paste them below.The text was updated successfully, but these errors were encountered: