Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
getlandsat package #58
Anyone that wants to use Landsat images - ecologists, map makers, etc.
None that I know of
Confirm each of the following by checking the box. This package:
Two things from initial check, not enough to hold up review:
Please check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide
The package includes all the following forms of documentation:
Estimated hours spent reviewing: 4.5
This package is very well done. I especially liked the caching functionality as the images can be somewhat large and slow to download. The functionality seems very self explanatory except for one thing. I am unsure of when to use
A statement of need
This is partially true, there is a clear statement in the README of what the package does, but not who the target audience is. Perhaps the section from the summary in the review issue could be added to the README as a more thorough explanation of the package goals and audience.
Installation instructions in the README worked perfectly and were very clear.
The vignette ran successfully and does demonstrate the major functionality in the paper. It might be helpful to talk a little bit in the vignette about what the
All exported functions are well documented in help. Easy to read and understand.
I ran into a problem with the following example:
lsat_cache_delete(files = lsat_cache_list())
within the function, there is the following line that duplicates a portion of the path.
files <- file.path(lsat_path(), "L8", dat$wrs_path, dat$wrs_row, dat$str, files)
Error: These files don't exist or can't be found: /Users/andeek/Library/Caches/landsat-pds/L8/001/003/LC80010032014272LGN00/L8/001/003/LC80010032014272LGN00/LC80010032014272LGN00_B1.TIF.ovr
Other than that, all examples work as expected.
I found a contributor code of conduct, but not a guide for how to contribute. The DESCRIPTION file is complete with
No problems with installation.
See the comment on examples for issue with
There were no unit tests for the caching functions, but I'm not sure if that's because it's specific to the user's machine so would be harder to write? All the other functions are tested extensively and pass on my machine.
will rbuildignore that ropensci/getlandsat#13
i think i stopped doing it cause it was failing for some weird reason, will get it back started
Thanks, i'll clarify ropensci/getlandsat#14
thanks, will do ropensci/getlandsat#15
okay, will do ropensci/getlandsat#16
I'll fix that and write a test for it, thanks ropensci/getlandsat#17
will add a
i think I avoided that as they would take a while to run, but i'll try to add some ropensci/getlandsat#19
thanks for noting, will add
thanks for noting, will add