Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider heuristics in guess_repo() #31

Closed
kevinykuo opened this issue Jul 16, 2019 · 2 comments · Fixed by #32
Closed

Consider heuristics in guess_repo() #31

kevinykuo opened this issue Jul 16, 2019 · 2 comments · Fixed by #32

Comments

@kevinykuo
Copy link
Contributor

Currently, guess_repo() returns all remotes. This means that in most collaborative settings where users have e.g. upstream and origin set up, the functions depending on guess_repo() won't work unless repo is explicitly provided. It might make sense to default to the upstream remote if it exists?
@cboettig
Copy link
Member

👍 Yeah, that makes sense to me. Want to send a PR for this?

@kevinykuo
Copy link
Contributor Author

Yep would be happy to send a PR

@kevinykuo kevinykuo mentioned this issue Jul 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

infer remote when there are multiple in guess_repo() kevinykuo/piggyback
2 participants
@cboettig @kevinykuo