Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add thank you to README #31

Closed
JasperHG90 opened this issue Jun 21, 2017 · 2 comments
Closed

Add thank you to README #31

JasperHG90 opened this issue Jun 21, 2017 · 2 comments
Assignees
@JasperHG90
Projects
v2.2

Comments

@JasperHG90
Copy link
Collaborator

No description provided.

@JasperHG90 JasperHG90 self-assigned this Jun 21, 2017
@JasperHG90 JasperHG90 added this to To do in v2.2 Jun 30, 2017
@juliasilge
Copy link
Collaborator

@JasperHG90 Should the people who were thanked be added as ctb, i.e. did they write a fair amount of code? I saw some of them listed in individual .R files as authors? In R packages, it's more typical to give attribution through the DESCRIPTION file rather thanking in the README, although of course the amount of code that results in ctb status varies from package to package, from maintainer to maintainer.

@juliasilge juliasilge reopened this Feb 4, 2019
@JasperHG90
Copy link
Collaborator Author

I'm fine with changing this. I wasn't sure how to do this at the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JasperHG90 JasperHG90

Labels
None yet
Projects
No open projects
v2.2
To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JasperHG90 @juliasilge