Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd linestring generation #13
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 7 9 +2
Lines 101 144 +43
=====================================
+ Hits 101 144 +43
Continue to review full report at Codecov.
|
|
looks good, just a few comments |
|
|
||
| for(j in seq_len(num_vertices-1)) { | ||
| bearing <- prior_bearing + runif(1, -0.5, 0.5) * max_rotation * 2 | ||
| distance <- runif(1, max = max_length) |
sckott
Dec 20, 2017
Member
can you do stats::runif here
can you do stats::runif here
| #' Random WKT linestring | ||
| #' | ||
| #' @export | ||
|
|
sckott
Dec 20, 2017
Member
nitpicky, but can you remove this empty line
nitpicky, but can you remove this empty line
| #' the line, numeric vector of the form \code{west (long), south (lat), east | ||
| #' (long), north (lat)}. optional | ||
| #' @param fmt (integer/numeric) number of digits. Default: 7 | ||
| #' @return WKT; a character vector with one or more POLYGON strings |
sckott
Dec 20, 2017
Member
s/POLYGON/LINESTRING
s/POLYGON/LINESTRING
|
I've added an extra commit as there was an issue with the wkt, which this web app http://arthur-e.github.io/Wicket/sandbox-gmaps3.html happily ignored. |
|
Hi Scott, I've added the requested changes. Samuel |
|
Sorry for all the extra commits, time to stop working for today. |
|
LGTM thanks so much for this contribution |
sckott
merged commit fea1394
into
ropensci:master
Hi,
I've added the creation of random linestrings, code structure is based on https://github.com/node-geojson/geojson-random/ but I've changed some parts to use spherical math.
Best,
Samuel