This repository has been archived by the owner on Sep 9, 2022. It is now read-only.
Add linestring generation #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 7 9 +2
Lines 101 144 +43
=====================================
+ Hits 101 144 +43
Continue to review full report at Codecov.
|
sckott
suggested changes
Dec 20, 2017
R/geo_linestring.R
Outdated
|
|
||
| for(j in seq_len(num_vertices-1)) { | ||
| bearing <- prior_bearing + runif(1, -0.5, 0.5) * max_rotation * 2 | ||
| distance <- runif(1, max = max_length) |
There was a problem hiding this comment.
can you do stats::runif here
R/wkt_linestring.R
Outdated
| #' Random WKT linestring | ||
| #' | ||
| #' @export | ||
|
|
There was a problem hiding this comment.
nitpicky, but can you remove this empty line
R/wkt_linestring.R
Outdated
| #' the line, numeric vector of the form \code{west (long), south (lat), east | ||
| #' (long), north (lat)}. optional | ||
| #' @param fmt (integer/numeric) number of digits. Default: 7 | ||
| #' @return WKT; a character vector with one or more POLYGON strings |
|
I've added an extra commit as there was an issue with the wkt, which this web app http://arthur-e.github.io/Wicket/sandbox-gmaps3.html happily ignored. |
|
Hi Scott, I've added the requested changes. Samuel |
sckott
approved these changes
Dec 20, 2017
|
Sorry for all the extra commits, time to stop working for today. |
|
LGTM thanks so much for this contribution |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've added the creation of random linestrings, code structure is based on https://github.com/node-geojson/geojson-random/ but I've changed some parts to use spherical math.
Best,
Samuel