You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Despite #113 , append and update are still slow due to the reliance on xml2. And this is the last part we need xml2.
I need to study the rapidxml code to learn how to modify the DOM tree with cpp.
The text was updated successfully, but these errors were encountered:
chainsawriot
changed the title
write_ods(append = TRUE) and write_ods(update = FALSE) are still slowwrite_ods(append = TRUE) and write_ods(update = TRUE) are still slow
Aug 18, 2023
I would actually guess that it would be faster to simply use a similar method to the current method of writing, and write the sheets with no headers to temp files and then concatenate them together, rather than trying to actually edit the XML tree itself in memory.
I guess you could make massive files by appending files that don't fit in memory this way, so you could write a file that you cannot then read, but it could be argued that this would in fact be the user's fault.
@pbrohan Given the fact that write_ods can now write list of data frames; an idea similar to yours is to read all sheets from the ODS file as list; modify the content of the list; and then write the list as ODS.
To me, it sounds fine (might still faster than xml2). The potential problem is that the roundtrip of read_ods and then write_ods is not lossless for ODS files produced from other sources (format, date, comments, merged cells and whatnot).
Despite #113 ,
append
andupdate
are still slow due to the reliance onxml2
. And this is the last part we needxml2
.I need to study the
rapidxml
code to learn how to modify the DOM tree with cpp.The text was updated successfully, but these errors were encountered: