Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put lat/lng from ip in a function #17

Closed
ateucher opened this issue Feb 21, 2014 · 6 comments
Closed

put lat/lng from ip in a function #17

ateucher opened this issue Feb 21, 2014 · 6 comments

Comments

@ateucher
Copy link
Member

I've started on this here: https://github.com/ateucher/rebird/blob/latlng_func/R/getlatlng.R

@karthik
Copy link
Member

karthik commented Feb 21, 2014

If you're moving this into a new function, you might as well format it as 39.833193,-94.862794 and return that. No additional processing needed on the other side.

@ateucher
Copy link
Member Author

You mean just as a two-element numeric vector? I think that's what I've done (at least I meant to)

@karthik
Copy link
Member

karthik commented Feb 21, 2014

Never mind. I thought ebirdgeo was taking this in as a character string. But looks like it's not the case

@karthik
Copy link
Member

karthik commented Feb 21, 2014

Also I don't think there is more to do on that fn. So you can just close this issue.

@ateucher
Copy link
Member Author

Cool, thanks. Should I wait for your PR to be merged before I submit one for this commit?

@karthik
Copy link
Member

karthik commented Feb 21, 2014

merged. Go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants